Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I fixed issue #94 per the comment -- added force_encoding statement #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

I fixed issue #94 per the comment -- added force_encoding statement #127

wants to merge 1 commit into from

Conversation

aglover
Copy link

@aglover aglover commented Apr 12, 2012

I had this issue in production and this fixed it for us.

#94

Change is simple -- xml_text.force_encoding 'utf-8'

@konstantin-dzreev
Copy link
Contributor

This does not seem to work with ruby 1.8.7

@aglover
Copy link
Author

aglover commented Apr 26, 2012

Yep, it isn't an issue on 1.8.7! :) I did not test pre-1.9.2. Sorry about that. Any suggestion other than checking RUBY_VERSION before the call?

@JoshReedSchramm
Copy link

Is anyone still looking at this pull request? If not I can pick it up and see if we can fix it in 1.8.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aglover @konstantin-dzreev @JoshReedSchramm